Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies of packages affected by functors migration #807

Merged
merged 3 commits into from
Feb 5, 2021

Conversation

JordanMartinez
Copy link
Contributor

@JordanMartinez JordanMartinez commented Feb 5, 2021

@JordanMartinez
Copy link
Contributor Author

Need to update profunctor-lenses to use new module name of Costar. Fix in purescript-contrib/purescript-profunctor-lenses#127:

[1/1 ModuleNotFound] src/profunctor-lenses/main/src/Data/Lens/Grate.purs:24:1

  24  import Data.Profunctor.Costar (Costar(..))
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  
  Module Data.Profunctor.Costar was not found.
  Make sure the source file exists, and that it has been provided as an input to the compiler.

           Src   Lib   All
Warnings   0     0     0  
Errors     1     0     1  
[error] Failed to build.
Error: Process completed with exit code 1.

@rhendric
Copy link
Member

rhendric commented Feb 5, 2021

Also, "contravariant" should be dropped from profunctor's list of dependencies.

@JordanMartinez
Copy link
Contributor Author

Thanks!

@JordanMartinez
Copy link
Contributor Author

Next error was due to css. Fix made in purescript-contrib/purescript-css#129

@JordanMartinez
Copy link
Contributor Author

css error can't be fixed until lookup is exported in foldable-traversable. Fix for that here: purescript/purescript-foldable-traversable#133

@JordanMartinez
Copy link
Contributor Author

JordanMartinez commented Feb 5, 2021

We have a sort of chicken-and-egg problem here... The prepare-0.14 package set does not yet include the updated dependency graphs, which is what this PR fixes. Thus, when CI in css attempts to build, it's using the dependency graph before we did the functors migration. To get css' CI to pass, we have to merge this PR first, even if this PR's CI doesn't currently build. It's either that or dropping css and all other packages that don't build in this PR, only to re-add them later.

This problem didn't happen until we hit contrib libraries because they switched to spago whereas core libraries still use bower.

@rhendric
Copy link
Member

rhendric commented Feb 5, 2021

Can the set in this PR reference the branch on which css's PR currently lives? Then we can keep finding libraries, creating PRs for them, and referencing them until this PR passes, at which point we can merge the library PRs even though they aren't green because this PR demonstrates that they would be green, and then this PR can point to the main branches again and finally merge?

@JordanMartinez
Copy link
Contributor Author

Can the set in this PR reference the branch on which css's PR currently lives? Then we can keep finding libraries, creating PRs for them, and referencing them until this PR passes, at which point we can merge the library PRs even though they aren't green because this PR demonstrates that they would be green, and then this PR can point to the main branches again and finally merge?

Hey! That's smart! And I've already tested this locally and it works fine once css gets fixed, so let's do it!

@JordanMartinez
Copy link
Contributor Author

I'll merge this PR once one of the core contributors approve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants