document laws #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyb
reviewed
May 8, 2017
src/Data/Distributive.purs
Outdated
| -- | - `distribute = collect id` | ||
| -- | - `distribute <<< distribute = id` | ||
| -- | - `collect f = distribute <<< map f` | ||
| -- | - `map f = runIdentity <<< collect (Identity <<< f)` |
There was a problem hiding this comment.
I guess we need an unwrap instead of runIdentity here?
Or perhaps we should use un Identity / un Compose in both of these to make it explicit?
There was a problem hiding this comment.
Good catch. My suspicion is that the potential users of this lib will be familiar with the unwrap idiom.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.