Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renderForeignError is not exported #53

Closed
berdario opened this issue Jan 14, 2017 · 1 comment
Closed

renderForeignError is not exported #53

berdario opened this issue Jan 14, 2017 · 1 comment

Comments

@berdario
Copy link
Contributor

renderForeignError is defined in Data.Foreign, but it doesn't seem to be used anywhere in there, and it's neither exported.

Can you change it to be exported?
@paf31
Copy link
Contributor

paf31 commented Jan 14, 2017

👍 Sounds good. Would you like to send a PR?

berdario added a commit to berdario/purescript-foreign that referenced this issue Jan 17, 2017
@berdario
Export renderForeignError
8061b8f 
Fixes purescript#53
@berdario berdario mentioned this issue Jan 17, 2017
Merged
@paf31 paf31 closed this as completed in #54 Jan 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paf31 @berdario