simplify null guard #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know why the build failed. :\ |
|
Don't worry about it, as @paf31 mentioned in another issue we need to do something to update the travis build to use the latest |
| @@ -25,7 +25,7 @@ class Index i where | |||
| foreign import unsafeReadPropImpl | |||
| """ | |||
| function unsafeReadPropImpl(f, s, key, value) { | |||
| if (value && typeof value === 'object') { | |||
| if (value != null && typeof value === 'object') { | |||
There was a problem hiding this comment.
I'm not sure we need the typeof here at all now, the if is only guarding against trying to read properties in a way that will raise runtime errors.
There was a problem hiding this comment.
Ah, nice! Updated to use a one-liner. :)
|
Ta 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could use
!== nullhere instead, sincetypeof undefinedis not'object', but as a general rule I avoid differentiating between null and undefined.