Update FFI and use runFnX #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyb
referenced
this pull request
in michaelficarra/purescript-spidermonkey-ast
Jul 20, 2014
also get rid of readExpr and make read total
| \ return Data_Either.Left('Value is not a ' + typeName + ''); \ | ||
| \ }; \ | ||
| \}" :: forall a. String -> Foreign -> Either String a | ||
| \}" :: Fn3 (String -> Either String Foreign) (Foreign -> Either String Foreign) String (Either String Foreign) |
There was a problem hiding this comment.
nb. Could give this a more general polymorphic type.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe this is the pattern we should encourage everywhere for FFIs, as now the implementations are safe from any further codegen changes too (unless we do something crazy).
Ideally we could be cleverer with
runFnX, as none of the calls in here will be inlined as the application isn't complete, but if we could inline definitions likereadPrimType,readMaybeImpl'where they just callrunFnXthen there's a better chance the full optimization will be applied later.