Add note explain why Except instead of Either #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paf31
reviewed
Feb 24, 2017
src/Data/Foreign.purs
Outdated
| @@ -81,6 +81,8 @@ renderForeignError (TypeMismatch exp act) = "Type mismatch: expected " <> exp <> | |||
|
|
|||
| -- | An error monad, used in this library to encode possible failures when | |||
| -- | dealing with foreign data. | |||
| -- | `Except e` was chosen instead of `Either e` because `Except`'s `Alt` instance | |||
There was a problem hiding this comment.
Could you add an extra newline here please, so that this gets rendered as two lines in the output?
There was a problem hiding this comment.
Also, nitpick: instead of "was chosen", I would prefer to phrase this more like "The Alt instance for Except allows us to accumulate multiple errors, unlike Either, or something along those lines.
There was a problem hiding this comment.
Good ideas. On second read, my phrasing was a bit awkward.
Updated.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've forever wondered what value is worth the price of putting
runExcepteverywhere. After asking, it seems like how they accumulate errors is the reason.