Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve names for toList, fromList. #51

Merged
merged 1 commit into from
Jan 11, 2016
Merged

Conversation

hdgarrood
Copy link
Contributor

Fixes #50

@garyb
Copy link
Member

garyb commented Dec 14, 2015

👍!

@paf31
Copy link
Contributor

paf31 commented Dec 14, 2015

👍 but I'm not looking forward to the downstream updates needed 😄

Does it make sense to turn these into aliases? Or is the issue that the names tend to collide with other things?

@hdgarrood
Copy link
Contributor Author

I haven't personally had problems with name collisions, I'm more interested in code readability. We could do aliases, although I would like to take advantage of being <1.0 while we still can - having both would feel like a wart. I can also volunteer for the downstream updates. :)

@hdgarrood
Copy link
Contributor Author

Speaking of which - does anyone have the incantation to list downstream libraries?

@garyb
Copy link
Member

garyb commented Dec 14, 2015

Maybe hold off on that? I have a thing I'm working on with a post-0.8-release of the Prelude that should probably be a released as a breaking-version to prevent our previous disasters with version problems after compiler updates.

@hdgarrood
Copy link
Contributor Author

Ah, ok. So maybe we should leave them in as aliases for now then?

toList and fromList are still exported, but they are now deprecated.
@hdgarrood
Copy link
Contributor Author

I've just amended this commit so that toList and fromList are still there as aliases, so that this can be merged without a major version bump. This way, people can start writing future-proof code now.

paf31 added a commit that referenced this pull request Jan 11, 2016
Improve names for toList, fromList.
@paf31 paf31 merged commit 186b949 into purescript:master Jan 11, 2016
@paf31
Copy link
Contributor

paf31 commented Jan 11, 2016

Perfect, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants