Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for v0.14.0-rc2 #16

Merged
merged 7 commits into from
Oct 8, 2020
Merged

Update for v0.14.0-rc2 #16

merged 7 commits into from
Oct 8, 2020

Conversation

JordanMartinez
Copy link
Contributor

No description provided.

src/Partial.js Outdated Show resolved Hide resolved
src/Partial/Unsafe.purs Show resolved Hide resolved
src/Partial/Unsafe.purs Outdated Show resolved Hide resolved
@JordanMartinez
Copy link
Contributor Author

I've addressed your concerns. Let me know whether there's anything else we need done.

@JordanMartinez
Copy link
Contributor Author

CI now builds. I didn't update the test code and that's what caused the failure.

Copy link
Member

@garyb garyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JordanMartinez JordanMartinez merged commit 7fb7e29 into purescript:master Oct 8, 2020
@JordanMartinez JordanMartinez deleted the upFor14 branch October 8, 2020 14:15
srghma added a commit to srghma/purescript-unique-lists that referenced this pull request Feb 7, 2021
…t/purescript-partial#16

in module Data.List.Unique
at .spago/unique-lists/master/src/Data/List/Unique.purs:19:24 - 19:44 (line 19, column 24 - line 19, column 44)

  Cannot import value unsafePartialBecause from module Partial.Unsafe
  It either does not exist or the module does not export it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants