Define Monoid instance for ReaderT #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
here is Monoid instance in action |
|
ping |
paf31
reviewed
May 2, 2017
src/Control/Monad/Reader/Trans.purs
Outdated
| @@ -72,6 +74,12 @@ instance monadReaderT :: Monad m => Monad (ReaderT r m) | |||
|
|
|||
| instance monadZeroReaderT :: MonadZero m => MonadZero (ReaderT r m) | |||
|
|
|||
| instance semigroupReaderT :: (Monad m, Semigroup a) => Semigroup (ReaderT s m a) where | |||
There was a problem hiding this comment.
only need Apply here, not a full Monad.
paf31
reviewed
May 2, 2017
src/Control/Monad/Reader/Trans.purs
Outdated
| instance semigroupReaderT :: (Monad m, Semigroup a) => Semigroup (ReaderT s m a) where | ||
| append = lift2 (<>) | ||
|
|
||
| instance monoidReaderT :: (Monad m, Monoid a) => Monoid (ReaderT s m a) where |
kritzcreek
reviewed
May 31, 2017
src/Control/Monad/Reader/Trans.purs
Outdated
| @@ -20,6 +20,8 @@ import Control.Monad.Trans.Class (class MonadTrans, lift) | |||
| import Control.Monad.Writer.Class (class MonadWriter, class MonadTell, pass, listen, tell) | |||
| import Control.MonadPlus (class MonadPlus) | |||
| import Control.MonadZero (class MonadZero) | |||
| import Data.Monoid (class Monoid, mempty) | |||
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.