Print error message on failed examples #3181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great; can you show a before/after example for when we hit this code path? |
|
Edited the original comment to include screencaps 😄 |
|
I think the "full error messages" part might be getting overwritten by the error message rendering; should we put a newline between that and the call to render the error messages? |
|
Since this seems to be the first of your contributions to get merged would you add yourself to the Very happy to have you on board! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a failed example provides a different error message than expected, it can be difficult to understand why.
This PR prints the given error message, which makes it easy to understand why the error occurred.
Before:
After: