Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make file paths clickable using pattern #3473

Merged
merged 1 commit into from Dec 15, 2018

Conversation

justinwoo
Copy link
Contributor

based on suggestion in #3472

@justinwoo
Copy link
Contributor Author

Results in this:

Warning found:
in module Components.Toggle
at src/Components/Toggle.purs:6:1 - 6:101

  The import of module React.Basic contains the following unused references:

    makeStateless

  It could be replaced with:

    import React.Basic (Component, JSX, StateUpdate(..), capture_, createComponent, make)



See https://github.com/purescript/documentation/blob/master/errors/UnusedExplicitImport.md for more information,
or to contribute content related to this warning.

cc @ad-si

@garyb
Copy link
Member

garyb commented Dec 3, 2018

I'm torn on this, since it's definitely less readable, and unless you are already familiar with the format, entirely cryptic. I know it's pretty common, but it always takes me a while to parse it.

Perhaps it's more a job for an option with PSA or something? I don't know.

@ad-si
Copy link

ad-si commented Dec 3, 2018

If you're reading it, you are already doing something wrong 😅. For me it's just an opaque identifier I click on (or select and paste) to get to the position. This could even be super charged with https://gist.github.com/egmontkob/eb114294efbcd5adb1944c9f3cb5feda

@justinwoo
Copy link
Contributor Author

Now prints this: (both link form and long form)

Warning 2 of 2:

  in module Main
  at src/Main.purs:15:1 - 19:27 (line 15, column 1 - line 19, column 27)

    No type declaration was provided for the top-level declaration of main.
    It is good practice to provide type declarations as a form of documentation.
    The inferred type of main was:

      Effect Unit


  in value declaration main

  See https://github.com/purescript/documentation/blob/master/errors/MissingTypeDeclaration.md for more information,
  or to contribute content related to this warning.

Copy link
Member

@LiamGoodacre LiamGoodacre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@LiamGoodacre LiamGoodacre merged commit b092961 into purescript:master Dec 15, 2018
@LiamGoodacre
Copy link
Member

Thanks!

@garyb garyb mentioned this pull request Jan 12, 2019
3 tasks
cyrilfretlink added a commit to cyrilfretlink/purs-loader that referenced this pull request Mar 4, 2019
cyrilfretlink added a commit to cyrilfretlink/purs-loader that referenced this pull request Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants