Add description field to manifest #173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this @thomashoneyman!
Yeah I think that's a good call. Note that we'd also need to update the README, as we embed the |
A library to build Google App Script with Purescript.
* Add package: peregrine * Oops, forgot the `.git` suffix
) In this commit we start turning the Bower-import machinery from a proof-of-concept that generates Manifests from some Bowerfiles to the "production" machine that will batch-import Bower packages into the Registry. To do this we have to: - introduce a more structured approach (a JSON file) in keeping track of what's wrong with the Bowerfiles that we try to convert to Registry `Manifest`s - have more lenient coercions that come from trying to parse them in an accommodating way
…try index (#210) * Add structured errors to bower import file * Remove unused deps * More structure to processing steps, collect errors * Remove unused import * Get it building * Something funky in the cache * Re-run cache and update reading registry index * Better error output and new exclusions file * Remove generated failures and manifests * Prep TODOs for @colinwahl * Update caches * Run updated cache and preserve exclusions * Minor versions fixup * Clean up steps * Match steps to existing code * Forgot to commit exclusions file * Rewrite a few more licenses * convert Bowerfile to Registry Manifest while importing from bower * Remove Step in favor of forPackage and clean up * Add bower-exclusions to gitignore * Encode and decode exclusions file JSON * Fix union in filter function * Add encoding to generic json * Don't check name matches and only throw on 404 * Remove redundant import * Throw ImportError on failure to fetch releases * Format * Update representation of PackageFailures with Either * Format Co-authored-by: Colin Wahl <colin.t.wahl@gmail.com>
* Treats semver as opaque type * Changes semvar to opaque type * Uses previous version of decode semver Co-authored-by: Thomas Honeyman <admin@thomashoneyman.com>
…bf-gun.git (#256) Co-authored-by: Thomas Honeyman <admin@thomashoneyman.com>
…stryIndex`, topologically sort a self-contained `RegistryIndex` (#264) * Add PackageGraph, add purescript-graphs dependency * Add bindings to maxSatisfying * Construct PackageGraph from RegistryIndex * Add checkRegistryIndex * Using Array is slightly faster with these collections * Optimization * Optimization * Fix build * Replace selfContainedDependencies check with constraint solving approach. TODO: Maintain these errors for reporting * Move self-contained registry check to end of LegacyImport, report amount of manifests with unsatisifed dependencies * Document Registry.PackageGraph * Update comments * Format Registry.Prelude * Modify checkRegistryIndex to only care if one version of each dependency is valid. Modify toPackageGraph to construct an each to each (dependency, version) pair for a given packagename dependency. Correct order for inOrder * Add check to verify packages are correctly sorted * Remove unused imports * Cleanup: fix exports & comments * Fix dependencies * clarify intent of progress * review feedback * some cleanup Co-authored-by: Thomas Honeyman <admin@thomashoneyman.com>
* Removes unsafe operation from main pipeline * Update spago.dhall * formatting Co-authored-by: Thomas Honeyman <admin@thomashoneyman.com> Co-authored-by: Fabrizio Ferrai <fabrizio.ferrai@gmail.com>
#180) Co-authored-by: Fabrizio Ferrai <fabrizio.ferrai@gmail.com>
Co-authored-by: Dirk Zimmermann <me@dirkz.com>
Co-authored-by: Thomas Honeyman <admin@thomashoneyman.com>
|
Superseded by #282 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starts fixing #124 by adding a description field.
Do we want to put any validation in place for description lengths? Tweet-length, perhaps?