Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests #31

Closed
f-f opened this issue Dec 5, 2018 · 5 comments
Closed

Add tests #31

f-f opened this issue Dec 5, 2018 · 5 comments

Comments

@f-f
Copy link
Member

f-f commented Dec 5, 2018 •
edited
Loading

There should be some tests so that we have some kind of assurance that we don't break stuff.

Anything is good to start, even just a bash script that installs the binary, runs some commands and checks that the return codes are all right.
This should prevent simple breakage, like what happened when 4e9c20e lead to #29
@f-f f-f mentioned this issue Dec 5, 2018
Closed
@justinwoo
Copy link
Contributor

These tests should probably also take into account the difference between Psc-Package projects using local-setup, insdhall and Spacchetti projects using whatever else

@f-f
Copy link
Member Author

f-f commented Dec 5, 2018 •
edited
Loading

Yeah, probably best to change the names of the psc-package-related commands, so like

  • spacchetti insdhall → spacchetti psc-package-install and
  • spacchetti local-setup → spacchetti psc-package-local-setup

@justinwoo
Copy link
Contributor

psc-package-insdhall, it's a big selling point for this tool

@justinwoo
Copy link
Contributor

It also needs some deprecation warnings since many of my other projects will break

@f-f
Copy link
Member Author

f-f commented Dec 5, 2018 •
edited
Loading

Right, then probably best to do the renaming of commands together with #23 so we don't break things

@f-f f-f mentioned this issue Dec 9, 2018
Merged
f-f added a commit that referenced this issue Dec 12, 2018
@f-f
Fix #31: add tests for most of spago commands
1bdcb9f
@f-f f-f mentioned this issue Dec 13, 2018
Closed
f-f added a commit that referenced this issue Dec 13, 2018
@f-f
Fix #31: add tests for most of spago commands
b56dfd0
@f-f f-f mentioned this issue Dec 13, 2018
Merged
@f-f f-f closed this as completed in #43 Dec 16, 2018
f-f added a commit that referenced this issue Dec 16, 2018
@f-f
Fix #31: add tests for most of spago commands
be3fa77
elliotdavies pushed a commit to elliotdavies/spago that referenced this issue Jul 1, 2019
@f-f
Fix purescript#31: add tests for most of spago commands
da4d99c
f-f added a commit that referenced this issue Sep 27, 2023
@f-f @klntsky
Consider something a builtin when there's no sourceSpan (#32)
3369f3e 
* Consider something a builtin when there's no sourceSpan

* Refactor `extractPackageName`

* Use module name to check if a declaration is built-in

* Recognize `Prim` module as built-in; add tests

* Code style

Fix #31

Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@justinwoo @f-f