New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration from Bower #272
Migration from Bower #272
Conversation
@jonathanlking I think we're done with the invasive changes to Bower-related code after #324, would you still like to work on this? If yes then we can rebase on #324, if not I can pick this up as it's needed for 1.0 anyways 馃檪 Also no worries about fixing #159 here, I'd be fine merging pretty much what you have here already (except we should remove the command line stuff) and tackling the rest in a later PR - the policy is that I'm fine even merging code that is not used anywhere yet if it's needed as a stepping stone for other things, as long as we don't change the CLI interface |
@f-f Thanks for letting me know 馃槃 |
@jonathanlking thank you! A few notes:
|
@jonathanlking I think if you merge jonathanlking#1 then it will pass CI |
Update to latest
@f-f thanks 馃檪 - I've merged it and fixed the warnings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jonathanlking! 馃檪
This reworks the prototype from #272 to provide a smooth migration from Bower when doing `spago init`
Description of the change
This (when completed) addresses #159.
Checklist:
README
P.S.: the above checks are not compulsory to get a change merged, so you may skip them. However, taking care of them will result in less work for the maintainers and will be much appreciated 馃槉