Generate GIT-REPO#version versions in bower.json for packages that are not found in Bower. #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Bower complain about it
…#version style bower dependency.
Dretch
commented
Jul 15, 2019
f-f
reviewed
Jul 16, 2019
f-f
reviewed
Jul 18, 2019
src/Spago/Bower.hs
Outdated
| deps <- Packages.getDirectDeps config | ||
|
|
||
| for deps $ \(PackageName{..}, Package{..}) -> do |
There was a problem hiding this comment.
I was wondering if we should do this in parallel, as from what I've seen bower info can be quite slow. We could use an async pool like we do here, or just mapTasks as we don't need the fancy error handling
There was a problem hiding this comment.
(this is not a requirement for merging, just noting that it might a bottleneck on larger packages)
There was a problem hiding this comment.
Yeah - done. Bower info is pretty slow (it takes a couple of seconds per call here, but I do have very high latency internet).
…because it is slow (~2s per call on my machine)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-on from #303.
Checklist: