Use div-root; fix examples' warnings #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -47,5 +47,6 @@ | |||
| </head> | |||
| <body> | |||
| <main id="main"></main> | |||
| <div id="root"></div> | |||
There was a problem hiding this comment.
I'm not totally following why this is required. Is the cookbook unable to use main id="main"? If not, and it seems important that we specifically use <div id="root">, then can we adjust the existing code (ie. the TryPureScript rendering) to point at this div and remove <main id="main">? It's a bit odd to have both.
There was a problem hiding this comment.
main is used to redirect Console.log (when under a TryPureScript.render =<< TryPureScript.withConsole, so that the strings logged to the console are instead added as nodes under the main id="main" HTML element rather than logging to the web browser's console.
I don't want the two to mix, so I'm creating a separate element for React usage.
thomashoneyman
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Fixes #283. Also allows updates the
frame.htmlfile to include a<div id="root"></div>. See JordanMartinez/purescript-cookbook#198Checklist: