Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show compiled JS based on query params only #296

Merged

Conversation

JordanMartinez
Copy link
Contributor

Description of the change

I noticed that using the view=output&js=true query params (e.g. https://try.purescript.org/?view=output&js=true) don't show the compiled JavaScript but rather shows a loading screen for forever. This is annoying because I can't just show others what PureScript's output looks like when they're curious.

This fixes that.


Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0 by @)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@JordanMartinez JordanMartinez merged commit 26b99bd into purescript:master Aug 13, 2022
@JordanMartinez JordanMartinez deleted the jam/view-code-via-link branch August 13, 2022 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants