Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend: Build the Product List/grid view Component for both light and dark mode #71

Closed
Lovelyfin00 opened this issue Jun 8, 2023 · 11 comments
Assignees
Labels
gssoc23 help wanted Extra attention is needed level3 Refactoring/ Adding functionalities

Comments

@Lovelyfin00
Copy link
Collaborator

Lovelyfin00 commented Jun 8, 2023

Issue Summary

The design for Product Product List/grid view as part of the Product component has been completed and now it needs to be built using our chosen tech stacks. The Product List/grid view has to be inside the Product component story

Figma link

The design for the Product List/grid view can be found here. Please make sure what you build follows the design.

Suggested fix

  • Build the Product List / grid view component following the design in the Figma file.
  • Make sure your codes are maintainable and legible.
  • After coding the component using React and scss, create storybook for the component.
  • Test it out on your end and make sure it's working properly.

Coding Rules

  • Let your codes look neat and readable
  • No unnecessary spacing and always leave one empty line after each code block
  • Separate each word with a hyphen - in your scss classes, ids.

PR Rules

  • Link the issue your PR is for by saying Fixes #PRNumber
  • Add a description of what your PR is about
  • Add screenshots or video of the working implementation of your PR

Preview

Light mode



Dark mode


@Lovelyfin00 Lovelyfin00 changed the title Frontend: Build the Product List/grid view Component Frontend: Build the Product List/grid view Component for both light and dark mode Jun 8, 2023
@Lovelyfin00 Lovelyfin00 added help wanted Extra attention is needed gssoc23 level3 Refactoring/ Adding functionalities labels Jun 8, 2023
@naveeng2402
Copy link

pl assign me to the issue

@Lovelyfin00
Copy link
Collaborator Author

Hey @naveeng2402
I'd like you to focus on one issue before showing interest in another

@naveeng2402
Copy link

Done👍

@Lovelyfin00
Copy link
Collaborator Author

Done with what exactly? @naveeng2402

@shivam-jainn
Copy link
Contributor

Has this issue been assigned to someone else?

@Lovelyfin00
Copy link
Collaborator Author

No @shivam-jainn
You can work on it before I review your other PR

@tripathishipra
Copy link

Hi , I am contributor under GSSOC'23 and I am eager to showcase my skills and make a meaningful contribution to this project.
Kindly assign me this issue. @Lovelyfin00

@shivam-jainn
Copy link
Contributor

shivam-jainn commented Jun 18, 2023 via email

@tripathishipra
Copy link

okay

@PatilHarshh
Copy link

@Lovelyfin00 this issue is still open, if yes , I am interested to contribute!

@Lovelyfin00
Copy link
Collaborator Author

Hey @PatilHarshh
It’s not available
There’s already a PR for it
You can checkout other frontend issues and new ones would be created tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc23 help wanted Extra attention is needed level3 Refactoring/ Adding functionalities
Projects
None yet
Development

No branches or pull requests

6 participants