Draft attempt in getting VirtualBox support #73
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@flavio-fernandes Awesome work thanks... Can you elaborate on what missing mappings there are? LMK, and we'll get this merged! |
|
I think is is benign to merge, but the missing mappings I'm referring to are here 1. |
|
@flavio-fernandes Two small issues above to fix. Thanks again! |
Conflicts: vagrant/Vagrantfile
|
Moved to #74 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a dry-run attempt in getting virtual-box to work with oh-my-vagrant.
While it should not disturb libvirt users, this is likely incomplete due to the
missing mappings in vb for Vagrant.configure().