Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button text (in French) too long on Android Lollipop #63

Open
marekkalnik opened this issue Jan 11, 2015 · 6 comments
Open

Button text (in French) too long on Android Lollipop #63

marekkalnik opened this issue Jan 11, 2015 · 6 comments
Assignees
Labels
Milestone

Comments

@marekkalnik
Copy link

marekkalnik commented Jan 11, 2015

Hi,

The button text is too log, so on my Nexus 4 I can not even see the button to vote :

screenshot_2015-01-11-21-27-29

I see that you're working on layout changes for Android in next version, but this seems to be rather urgent. Maybe a quick and dirty solution would be to replace text in French translation (and other where it is too long), by something like that :

Current Short
Me le rappeler ultérieurement Plus tard
Votez maintenant Voter

Another possible solution would be to implement different text by OS.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/7659308-button-text-in-french-too-long-on-android-lollipop?utm_campaign=plugin&utm_content=tracker%2F1192251&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F1192251&utm_medium=issues&utm_source=github).
@pushandplay
Copy link
Owner

@marekkalnik Hi, I know, this bug and it will be fixed in next release. see #37

@pushandplay pushandplay added this to the v 1.2.0 milestone Jan 11, 2015
@pushandplay pushandplay self-assigned this Jan 11, 2015
@pushandplay
Copy link
Owner

@marekkalnik you can use custom custom Locale object for overwrite text strings

@tryagains
Copy link

I have issue with cancelButtonLabel and laterButtonLabel having a large space between each other. Is that related to this issue?

@pushandplay
Copy link
Owner

@tryagains Hi, yes, it is related

@ersingencturk
Copy link
Contributor

same happening for turkish local too.
could be better if the order of the buttons can be replaced by moving yes rate to the beginning.

As you can see from the screenshot I see two NO buttons and no option to go actually to rate the app

screen shot 2015-07-01 at 09 00 51

ersingencturk added a commit to OnlinePeople/cordova-plugin-apprate that referenced this issue Sep 25, 2015
workaround for buttons not fitting :
pushandplay#63
@pablo-gonzalez
Copy link

Is this project still maintened? I have read several issues in the second part of 2015 and no anwers at all.
I am facing the issue with Android (my version is 5.1.1) when the rate button is not shown using Portuguese locale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants