Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweaks + tests #68

Merged
merged 23 commits into from
Aug 24, 2015
Merged

Tweaks + tests #68

merged 23 commits into from
Aug 24, 2015

Conversation

jpatel531
Copy link
Contributor

Just tightening up code + making event + method names a bit more obvious.

@jpatel531
Copy link
Contributor Author

Throws an error if editor / buffer is of unexpected type, making issues such as #62 #58 etc. easier to diagnose

@jpatel531
Copy link
Contributor Author

  • When partner is typing, the SharePane they're typing in has a little pencil icon over it.
  • Tab names are synced over so people know better what they're working on

@jpatel531 jpatel531 force-pushed the tweaks branch 7 times, most recently from 5aa6658 to e85594c Compare August 15, 2015 23:19
@jpatel531 jpatel531 changed the title Tweaks Tweaks + tests Aug 15, 2015
@jpatel531 jpatel531 mentioned this pull request Aug 17, 2015
Merged
@jpatel531 jpatel531 mentioned this pull request Aug 20, 2015
Closed
@jpatel531
Copy link
Contributor Author

Obv needs rebase

@jpatel531 jpatel531 force-pushed the tweaks branch 5 times, most recently from c27a65d to 2845346 Compare August 23, 2015 23:13
jpatel531 added a commit that referenced this pull request Aug 24, 2015
@jpatel531
Merge pull request #68 from pusher/tweaks
df1b394 
Tweaks + tests
@jpatel531 jpatel531 merged commit df1b394 into master Aug 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jpatel531