This repository has been archived by the owner on Oct 13, 2021. It is now read-only.
Use dynamicCodec for decoding errors #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JoelSpeed: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
samuelyallop-pusher
approved these changes
Apr 2, 2019
| @@ -305,7 +305,8 @@ func (a *Applier) configFor(gv schema.GroupVersion) (*rest.Config, error) { | |||
| config.APIPath = "apis/" | |||
| } | |||
|
|
|||
| config.NegotiatedSerializer = serializer.NegotiatedSerializerWrapper(runtime.SerializerInfo{Serializer: unstructured.UnstructuredJSONScheme}) | |||
| contentConfig := resource.UnstructuredPlusDefaultContentConfig() | |||
| config.NegotiatedSerializer = contentConfig.NegotiatedSerializer | |||
There was a problem hiding this comment.
Suggested change
| config.NegotiatedSerializer = contentConfig.NegotiatedSerializer | |
| config.NegotiatedSerializer = resource.UnstructuredPlusDefaultContentConfig().NegotiatedSerializer |
Maybe.
There was a problem hiding this comment.
It makes the line really long so I'm tempted to skip this suggestion /shrug
|
/test 1.13 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix enables proper decoding of Kubernetes API errors and converts useless messages such as
error creating object: the server rejected our request for an unknown reason (post deployments.apps)into proper error messages likeerror creating object: dryRun is not supported yetCC @samuelyallop-pusher