This repository has been archived by the owner on Oct 13, 2021. It is now read-only.
Handle gittracks flag #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielMorsing
force-pushed
the
handleGittracks-flag
branch
from
40f7508
to
8c09c09
Compare
|
/retest |
|
see #171 for previous comments and context |
JoelSpeed
reviewed
Sep 24, 2019
There was a problem hiding this comment.
Got one nit but other than that everything looks good
Any chance you could squash the commits a little bit? Don't tend to like fixup and WIP in commit messages if possible, commits should be a logical history of the functional changes by the time they hit master
|
|
||
| var key = types.NamespacedName{Name: "example", Namespace: "default"} | ||
| var expectedRequest = reconcile.Request{NamespacedName: key} | ||
|
|
||
| const timeout = time.Second * 5 | ||
| const consistentTimeout = 1 * time.Second |
There was a problem hiding this comment.
Nit but we normally have this called consistentlyTimeout in our other tests
DanielMorsing
force-pushed
the
handleGittracks-flag
branch
from
8c09c09
to
8849fb8
Compare
|
Fixed up that last suggestion and pruned the history |
added 5 commits
September 24, 2019 14:00
Also remove a test that checked on running disabled CGT, since it is now a panic
DanielMorsing
force-pushed
the
handleGittracks-flag
branch
from
8849fb8
to
35ae026
Compare
|
/retest |
mthssdrbrg
reviewed
Sep 24, 2019
mthssdrbrg
approved these changes
Sep 24, 2019
|
/retest |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to thumbs for fingers, I managed to close the last PR by merging it into another branch
This PR adds the gittrack mode flag and adds tests for watches being disabled when handling them is disabled