Skip to content
This repository has been archived by the owner on Nov 17, 2022. It is now read-only.

[IS-618] - Add support for new node label schema #62

Merged
merged 2 commits into from Aug 20, 2019

Conversation

theobarberbany
Copy link
Contributor

In Kubernetes v1.16 the old schema node-role.kubernetes.io/type is being removed. This PR adds support for the new kubernetes.io/role=type schema.

@theobarberbany theobarberbany requested a review from a team August 19, 2019 16:05
@theobarberbany
Copy link
Contributor Author

/build docker

Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some suggestions for possible improvements, WDYT?

nodes/nodes.go Outdated Show resolved Hide resolved
nodes/nodes.go Outdated Show resolved Hide resolved
nodes/nodes.go Outdated Show resolved Hide resolved
nodes/nodes.go Outdated Show resolved Hide resolved
nodes/nodes_test.go Outdated Show resolved Hide resolved
rescheduler.go Show resolved Hide resolved
@theobarberbany theobarberbany force-pushed the update-nodelabels branch 2 times, most recently from 780fdf5 to a6cce8b Compare August 20, 2019 10:32
@pusher-ci pusher-ci added size/L and removed size/M labels Aug 20, 2019
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of wording suggestions as possible improvements

rescheduler.go Outdated Show resolved Hide resolved
rescheduler.go Outdated Show resolved Hide resolved
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theobarberbany theobarberbany merged commit cdb0b2b into master Aug 20, 2019
@pusher-ci pusher-ci deleted the update-nodelabels branch August 20, 2019 10:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants