This repository has been archived by the owner on Nov 17, 2022. It is now read-only.
[IS-618] - Add support for new node label schema #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/build docker |
JoelSpeed
reviewed
Aug 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some suggestions for possible improvements, WDYT?
theobarberbany
force-pushed
the
update-nodelabels
branch
2 times, most recently
from
August 20, 2019 10:32
780fdf5
to
a6cce8b
Compare
JoelSpeed
reviewed
Aug 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of wording suggestions as possible improvements
theobarberbany
force-pushed
the
update-nodelabels
branch
from
August 20, 2019 10:46
a6cce8b
to
630ec09
Compare
JoelSpeed
approved these changes
Aug 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Kubernetes v1.16 the old schema
node-role.kubernetes.io/type
is being removed. This PR adds support for the newkubernetes.io/role=type
schema.