Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on unsubscribing from a nil channel #39

Closed
soffes opened this issue Apr 24, 2012 · 3 comments
Closed

Crash on unsubscribing from a nil channel #39

soffes opened this issue Apr 24, 2012 · 3 comments

Comments

@soffes
Copy link

soffes commented Apr 24, 2012

I can reproduce this every time with the nightly using the following code:

[self.pusherClient unsubscribeFromChannel:nil];

The workaround is to check for nil before unsubscribing.

@soffes
Copy link
Author

soffes commented Apr 24, 2012

Per our conversation on Twitter, it should throw an exception or assert if this is nil.

@lukeredpath
Copy link
Contributor

I'm strongly in favour of enforcing the contract of not passing nil to this method, so I'll likely add an assertion to assist debugging.

@soffes
Copy link
Author

soffes commented Apr 24, 2012

Sounds great. You won me over :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants