Auth errors not getting bubbled up

[AquaGeek]

If the authentication operation fails at the

- (void)connection:(NSURLConnection *)connection didFailWithError:(NSError *)error

level, the error is not getting bubbled back up the chain so the caller has no idea if something went wrong. I accidentally mistyped the hostname for my authentication URL and couldn't figure out why nothing was happening.

[lukeredpath]

Your right, the underlying connection error should be bubbled up. But you still should have been getting a call to the pusher:didFailToSubscribeToChannel:withError delegate call.

I'm enhancing this delegate call to include the underlying error if there is one.

[lukeredpath]

Ah, I see the problem, the underlying connection was just calling [self setFinished:YES] in the didFailWithError method, when it should be calling [self finish], which is overridden in PTPusherChannelAuthorizationOperation to start the callback chain.

[AquaGeek]

Thanks for fixing this!