Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Carthage info to Readme #65

Closed
emilkarl opened this issue Jun 18, 2018 · 7 comments
Closed

Include Carthage info to Readme #65

emilkarl opened this issue Jun 18, 2018 · 7 comments

Comments

@emilkarl
Copy link

These steps should not be left out from docs about Carthage. There also seems to be a need to specify --platform ios now otherwise its installed into Build/Mac.

https://github.com/Carthage/Carthage#if-youre-building-for-ios-tvos-or-watchos

image

@emilkarl
Copy link
Author

Missing "Always embed swift libraries"

teamtailormobile xcodeproj 2018-06-18 11-11-38


Also missing info about making Framwork Search Paths recursive

monosnap 2018-06-18 11-06-00

@lukabratos
Copy link
Contributor

Hi @emilkarl

That's interesting. I've ran carthage update and it generated two folders; one for iOS and another one for Mac. Which version of Carthage are you using?

Our SDK supports both platforms (iOS, Mac) so it would be incorrect to specify platform just as --platform ios.

Thanks for your feedback, I will take your thoughts into consideration.

@emilkarl
Copy link
Author

Mine did not create iOS, only mac if I did not specify platform like that? Strange. @lukabratos

@moaxaca
Copy link

moaxaca commented Oct 6, 2018

@emilkarl I had a similar issue, but after updating to xCode 10.0 (dangerous) I was able to get Carthage generating iOS and code signing working.

Here is a good reference for anyone else dealing with app store submission issues:
https://github.com/Carthage/Carthage#if-youre-building-for-ios-tvos-or-watchos
http://www.openradar.me/radar?id=6409498411401216

I was receiving: Code signing "PushNotifications.framework" failed.
In the logs I had: /Root/Payload/openroads.app/Frameworks/PushNotifications.framework: code object is not signed at all

@aatalyk
Copy link

aatalyk commented Nov 11, 2018

Hi @moaxaca, how did you solve the issue with App Store submission could you provide more info on this?

@moaxaca
Copy link

moaxaca commented Nov 11, 2018

@aatalyk So my issue was really around following the install instructions in the master branch of this repo. They got me up and running for development but failed the signing process. Reference image below:

screen shot 2018-11-11 at 9 31 16 am

I eventually went back to the Carthage docs and read their installation instructions. Probably should have done that first X).

Here is a reference:
https://github.com/Carthage/Carthage#if-youre-building-for-ios-tvos-or-watchos

I simply added the correct build phase hooks, my configuration in an image below, and everything signed and submitted correctly.

screen shot 2018-11-11 at 9 33 17 am

Hope this help!

lukabratos pushed a commit that referenced this issue Nov 12, 2018
Add detailed information about how to build the dependency with Carthage and integrate it into the project.

Fixes #65
@lukabratos
Copy link
Contributor

I have updated the readme file with more detailed installation instructions, here.
Hopefully this step by step guide from the official documentation will be enough to reduce the confusion.

Thanks for flagging this issue and apologies for any inconvenience caused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants