Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subscribe #66

Merged
merged 3 commits into from Jun 19, 2018
Merged

Fix subscribe #66

merged 3 commits into from Jun 19, 2018

Conversation

lukabratos
Copy link
Contributor

What?

Move ⬇️ out of the if Device.idAlreadyPresent() statement.

persistenceService.persist(interest: interest)
            localStorageQueue.async {
                persistenceService.persist(interest: interest)
                completion()
            }

CC @pusher/mobile

@codecov-io
Copy link

codecov-io commented Jun 19, 2018

Codecov Report

Merging #66 into master will increase coverage by 16.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #66       +/-   ##
===========================================
+ Coverage   80.97%   97.02%   +16.04%     
===========================================
  Files          29       16       -13     
  Lines         983      538      -445     
===========================================
- Hits          796      522      -274     
+ Misses        187       16      -171
Impacted Files Coverage Δ
Tests/SDKTests.swift 100% <100%> (ø) ⬆️
Tests/MetadataTests.swift 89.65% <100%> (ø) ⬆️
Sources/SystemVersion.swift
Sources/Device.swift
Sources/NetworkService.swift
Sources/PublishId.swift
Sources/ReportEventType.swift
Sources/Instance.swift
Sources/DeviceTokenHelper.swift
Sources/PersistenceService.swift
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4545a57...e80788d. Read the comment docs.

@luismfonseca
Copy link
Contributor

Add regression test + update changelog :o

@lukabratos lukabratos merged commit d815421 into master Jun 19, 2018
@lukabratos lukabratos deleted the fix-subscribe branch June 19, 2018 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants