Update array_walk to a foreach loop when validating channels #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also fixes the reference mismatch I fixed in #43, so I will close my PR (but it is still interesting to read about reference mismatches) |
|
Interesting. That's good to know going forward. I'm more inclined to just stick to regular loops in the future. They may be a bit less elegant, but PHP's existing solution to mapping over arrays is far from elegant, and after these issues, does not seem as robust. |
|
@WillSewell we do have a test that uses multiple channel names. https://github.com/pusher/pusher-http-php/blob/master/test/unit/triggerUnitTest.php#L50 But our travis tests don't run against 5.2: Which is why we didn't catch that. 👍 for using normal "less elegant" |
Referencing a private method in array_walk is incompatible with PHP 5.2
WillSewell
force-pushed
the
fix_php_52_incompatability
branch
from
ea9b754
to
b606249
Compare
WillSewell
added a commit
that referenced
this pull request
May 15, 2015
Update array_walk to a foreach loop when validating channels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referencing a private method in array_walk is incompatible with PHP 5.2
@leggetter @mdpye