Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OpenSSL vs Ruby HMAC #22

Closed
metaskills opened this issue May 6, 2012 · 2 comments
Closed

Use OpenSSL vs Ruby HMAC #22

metaskills opened this issue May 6, 2012 · 2 comments

Comments

@metaskills
Copy link

So I was just looking at using pusher for the first time and as I typically do, I review its gem dependencies. When I did a little research on Ruby HMAC, I found that its project page is abandoned and that they recommend using OpenSSL instead. The links are below.

https://github.com/topfunky/ruby-hmac
http://blog.nathanielbibler.com/post/63031273/openssl-hmac-vs-ruby-hmac-benchmarks

Has this come up before? Would you be open to a pull request for the update?

@metaskills
Copy link
Author

Made a gist with an updated benchmark in context of how Pusher uses Ruby HMAC. https://gist.github.com/2607144

@mloughran
Copy link
Contributor

Thanks for bringing this up Ken, I've committed a change which will be in the next release. If you're looking at dependencies you'll also notice that the signature gem relies on ruby-hmac - that will also be fixed in the next release. Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants