Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure multiple driver enabling directly through API #17

Closed
wants to merge 4 commits into from

Conversation

lukis101
Copy link
Contributor

Also threw in the fix to apply calibration to reference devices (like vice or index basestations, might need testing on uncommon setups)

Left old config file method as a renamed launch command
Been running Rift CV1 with Steamvr 2.0 basestations for a while and did not run into any problems so far even when purely on Index. The lighthouse driver station poses update on their (re)initialisation or some speciffic(dynamic recalibration?) cases and not immediately.
OpenVR-SpaceCalibrator/Configuration.cpp Show resolved Hide resolved
@@ -298,7 +298,7 @@ void ScanAndApplyProfile(CalibrationContext &ctx)
continue;
}

if (deviceClass == vr::TrackedDeviceClass_TrackingReference || deviceClass == vr::TrackedDeviceClass_HMD)
if (/*deviceClass == vr::TrackedDeviceClass_TrackingReference ||*/ deviceClass == vr::TrackedDeviceClass_HMD)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't do this originally because it didn't work (the offsets wouldn't be reflected in the steamvr menu). I guess it works now?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this out and it still does not work with v1 lighthouses. Is it working for a different type of reference @lukis101?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had written my findings in commit description, copypasting with a lil more:
Does work with 2.0 stations and CV1, do not have 1.0s to test but other user on Discord had confirmed it working.
The lighthouse driver station poses get updated on their (re)initialization or some specific(dynamic recalibration?) cases and not immediately. So the offsets do get applied either when starting trackers after SteamVR is fully loaded, or by causing all LH devices to loose tracking (and thus disappear along with the chaperone corruption)

pushrax added a commit that referenced this pull request Apr 6, 2020
@pushrax
Copy link
Owner

pushrax commented Apr 6, 2020

Merged manually in 9744585 - thanks!

@pushrax pushrax closed this Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants