Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#12 Add Hapi plugin #14

Merged
merged 10 commits into from
Sep 21, 2019
Merged

#12 Add Hapi plugin #14

merged 10 commits into from
Sep 21, 2019

Conversation

batrudinych
Copy link
Collaborator

@batrudinych batrudinych commented Sep 21, 2019 •
edited by puzpuzpuz

Closes #12 - added Hapi plugin.

By the way, shouldn't @types/node be explicitly added as a dev dep?

@batrudinych batrudinych mentioned this pull request Sep 21, 2019
Closed
@puzpuzpuz puzpuzpuz self-requested a review September 21, 2019 11:22
@puzpuzpuz puzpuzpuz added the enhancement New feature or request label Sep 21, 2019
@puzpuzpuz puzpuzpuz added this to the 1.3.0 milestone Sep 21, 2019
@puzpuzpuz
Copy link
Owner

By the way, shouldn't @types/node be explicitly added as a dev dep?

At the moment TS typings are not validated by a tsc call, so this dep is not required. But it may be a good idea to start validating typings. I'll create a GH issue for that enhancement.

@puzpuzpuz puzpuzpuz mentioned this pull request Sep 21, 2019
Closed
puzpuzpuz
puzpuzpuz requested changes Sep 21, 2019
View reviewed changes
Copy link
Owner

@puzpuzpuz puzpuzpuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution! The PR looks really great.

I've left some minor comments to address.

README.md Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
aigoncharov
aigoncharov previously requested changes Sep 21, 2019
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
@puzpuzpuz puzpuzpuz self-requested a review September 21, 2019 15:24
@puzpuzpuz puzpuzpuz dismissed aigoncharov’s stale review September 21, 2019 15:25

All comments were resolved

@puzpuzpuz puzpuzpuz merged commit e54d2d2 into puzpuzpuz:master Sep 21, 2019
@batrudinych batrudinych deleted the feature/#12 branch September 21, 2019 15:26
@batrudinych batrudinych restored the feature/#12 branch September 21, 2019 15:27
@batrudinych batrudinych deleted the feature/#12 branch September 21, 2019 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puzpuzpuz puzpuzpuz puzpuzpuz approved these changes

@aigoncharov aigoncharov aigoncharov left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

Support Hapi
3 participants
@batrudinych @puzpuzpuz @aigoncharov