Combine top hash caching with bucket chaining #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puzpuzpuz
force-pushed
the
reintroduce-bucket-chaining-in-map
branch
from
42de99a
to
64f7b60
Compare
Codecov ReportBase: 93.10% // Head: 94.57% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
==========================================
+ Coverage 93.10% 94.57% +1.47%
==========================================
Files 6 6
Lines 725 830 +105
==========================================
+ Hits 675 785 +110
+ Misses 40 36 -4
+ Partials 10 9 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
puzpuzpuz
force-pushed
the
reintroduce-bucket-chaining-in-map
branch
2 times, most recently
from
b7f81fc
to
10247e9
Compare
puzpuzpuz
force-pushed
the
reintroduce-bucket-chaining-in-map
branch
from
10247e9
to
84c4b68
Compare
This was referenced Oct 15, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reintroduces bucket chaining, so that the map can cope with poor quality hash functions. This is a required preliminary step for #46.
According to some local testing on my machine, map performance is not affected.