Keycloak SSO spike #70
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add gem for openid-connect, which is the protocol we are interested in - add some helpers (probably they belong into the login-controller) that match the try-and-error result from the rails console
OTOH, this might be better solved with 3-4 ENV-vars...
might be a useless idea, kill it if you want to
codez
reviewed
Oct 28, 2019
| redirect_to params[:ref].presence || root_path | ||
| else | ||
| flash[:alert] = 'Ungültige Benutzerdaten' | ||
| end |
There was a problem hiding this comment.
Warum nicht konfigurierbar? Falls Settings.keycloak.server gesetzt via OpenId, sonst via DB. Der Mehraufwand ist minim, die Möglichkeit, pTime weiterhin ohne Keycloak betreiben zu können, bestimmt für irgendwen interessant.
Kagemaru
force-pushed
the
master
branch
2 times, most recently
from
34dc613
to
094f6d6
Compare
Kagemaru
force-pushed
the
master
branch
2 times, most recently
from
be9e9a2
to
d09a88e
Compare
Kagemaru
force-pushed
the
master
branch
4 times, most recently
from
b7e8e68
to
b84f926
Compare
Kagemaru
force-pushed
the
master
branch
5 times, most recently
from
0c66df4
to
6b619e0
Compare
|
As you spoke in actual code, this spike is but a spook by now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a basis for discussion, this adds some ideas to implement SSO with keycloak. The only thing binding this to keycloak instead of any other OpenID-Connect server is the naming of variables, though. Maybe also some pathname-assumptions, as well.
To support another server (-type), only the clients needs to be configured differently. The flow should stay the same.