Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger to obj #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Logger to obj #10

wants to merge 1 commit into from

Conversation

notbenh
Copy link

@notbenh notbenh commented Oct 19, 2010

Sorry that I didn't make this a proper assert based test, I might get to that later but the issue was that I was running in to an error when I called runner->run_test_suite on it's own. The issue is that runner->run converts logger the class name to logger the object, but when you don't use 'run' you start seeing warnings about not being able to use a string as an object.

I'm not exactly sure if this is the best method as every call to runner->logger will check the type for $self->{logger} and that seems needless but it does allow for things to 'do the right thing' for all the existing code with out having to add some check to all the run* methods, also if there ever is a need to change loggers mid stream (though doubt thats a useful case to account for?).

Either way this solved my case but it's not the most 'normal' case so this could just be needless and I should be doing the check on my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant