Updated the polyfit function to np.polynomial.Polynomial.fit() #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwhanse
added
the
dependency
cwhanse
reviewed
Jan 4, 2022
pvanalytics/util/_fit.py
Outdated
| coefficients = np.polyfit(xs, ys, 2) | ||
| return np.poly1d(coefficients) | ||
| # fit a quadratic function of `xs` to the data in `ys` | ||
| coefficients = list(np.polynomial.Polynomial.fit(xs, ys, 2).convert()) |
There was a problem hiding this comment.
I think if you use polynomial.polyfit and flipud this would be simpler.
There was a problem hiding this comment.
Tried it out and verified same results--thank you for the suggestion @cwhanse !
cwhanse
approved these changes
Jan 4, 2022
|
@cwhanse what's our policy here on merging PR's in this package, ie are there a certain amount of reviewers I need to check off on this? Or are we good to merge and close now? |
|
@kperrynrel was just thinking about that. If either Will or I approve and we don't indicate that the other needs to look, then it's OK to merge. If your work is held up by a PR, feel free to nag us about it. |
|
Awesome, thanks for the clarification @cwhanse ! |
cwhanse
added a commit
that referenced
this pull request
Jan 7, 2022
Merged
cwhanse
added a commit
that referenced
this pull request
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses issue #119, by updating the np.polyfit() function to newer np.polynomial.Polynomial.fit() function.