Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linear Algebra Error thrown in earlier numpy versions when running orientation fixed_nrel() function. #119

Closed
kperrynrel opened this issue Jan 4, 2022 · 5 comments
Assignees
Milestone

Comments

@kperrynrel
Copy link
Member

Following error is thrown when running fixed_nrel() function on a azimuth/tilt estimation pipeline:

raise LinAlgError("SVD did not converge in Linear Least Squares")

LinAlgError: SVD did not converge in Linear Least Squares

This occurred when running numpy=1.19.1. Updated to numpy 1.19.5 and issue was resolved. Need to update minimum numpy installation.

@kperrynrel kperrynrel self-assigned this Jan 4, 2022
@cwhanse
Copy link
Member

cwhanse commented Jan 4, 2022

@kperrynrel which version of scipy was used when the error was reported?

@cwhanse
Copy link
Member

cwhanse commented Jan 4, 2022

Ah, nvm I see the issue. This helper function uses np.polyfit which is the old numpy API, not yet deprecated AFAIK but less well-mannered than its replaced np.polynomial. We should bring the helper function up to the newer API; transition guide here.

@kperrynrel
Copy link
Member Author

I can do that @cwhanse, will cut a PR making an update on that function.

@kandersolar
Copy link
Member

Closed by #120?

@kperrynrel
Copy link
Member Author

@kanderso-nrel correct. Closing this--thanks for tracking housekeeping on this!

@kandersolar kandersolar added this to the v0.1.1 milestone Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants