Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated and possibly unused environment.yaml #1133

Closed
Peque opened this issue Jan 19, 2021 · 1 comment · Fixed by #1134
Closed

Remove outdated and possibly unused environment.yaml #1133

Peque opened this issue Jan 19, 2021 · 1 comment · Fixed by #1134
Milestone

Comments

@Peque
Copy link
Contributor

Peque commented Jan 19, 2021

The file docs/environment.yaml seems to be outdated as it is not possible to generate the documentation with a virtualenvironment created based on that file. It is currently missing dataclasses (since it declares use of Python 3.6), sphinx-gallery, sphinx-toggleprompt and Pillow.

Since all those dependencies and the dataclasses requirement for Python 3.6 is already handled in setup.py, I think the docs/environment.yaml could be simply removed to avoid confusion and duplicated dependencies declaration.

Peque added a commit to Peque/pvlib-python that referenced this issue Jan 19, 2021
@wholmgren
Copy link
Member

correct, the doc build uses an environment specified by pip install pvlib[doc]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants