Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model Chain PVwatt simple typo #1731

Closed
cpullium opened this issue May 10, 2023 · 1 comment · Fixed by #1793
Closed

Model Chain PVwatt simple typo #1731

cpullium opened this issue May 10, 2023 · 1 comment · Fixed by #1793
Labels
easy good first issue help wanted
Milestone
0.10.0

Comments

@cpullium
Copy link

In the example of the Model Chain the wrong variable is given for inverter parameter.
image

It should be pdc0... (dc not ac)
@kandersolar
Copy link
Member

@cpullium want to submit a PR to fix that typo?

@cwhanse cwhanse mentioned this issue Jun 27, 2023
Closed
@kandersolar kandersolar added this to the 0.10.0 milestone Jun 29, 2023
kandersolar added a commit to kandersolar/pvlib-python that referenced this issue Jun 29, 2023
@kandersolar
fix pvlib#1731
9234ff1
@kandersolar kandersolar linked a pull request Jun 29, 2023 that will close this issue
Finalize 0.10.0 #1793
Merged
3 tasks
kandersolar added a commit that referenced this issue Jun 30, 2023
@kandersolar
Finalize 0.10.0 (#1793)
6bf9e07 
* move 0.9.6 whatsnew content to 0.10.0

* cleanup

* Add missing contributors

* fix #1731

* create blank 0.10.1 whatsnew

* fix contributor gh handle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy good first issue help wanted
Projects
None yet
Milestone
0.10.0
Development

Successfully merging a pull request may close this issue.

Finalize 0.10.0 kandersolar/pvlib-python
3 participants
@cwhanse @cpullium @kandersolar