Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pvsystem.sapm_celltemp #54

Closed
wholmgren opened this issue Apr 22, 2015 · 1 comment
Closed

pvsystem.sapm_celltemp #54

wholmgren opened this issue Apr 22, 2015 · 1 comment
Labels
api
Milestone
0.2

Comments

@wholmgren
Copy link
Member

The pvsystem.sapm_celltemp function currently returns a dict {'tcell':tcell, 'tmodule':tmodule}. I think it should return a DataFrame with the keys temp_cell and temp_module (as described in the wiki).

I actually like the simplicity of the function parameter names here, but maybe they too should be changed.
@wholmgren wholmgren added the api label Apr 22, 2015
@bmu bmu added this to the 0.2 milestone Apr 23, 2015
@bmu
Copy link
Contributor

bmu commented Apr 23, 2015

I think they should be changed.

@wholmgren wholmgren mentioned this issue Apr 23, 2015
Closed
wholmgren added a commit to wholmgren/pvlib-python that referenced this issue Jun 22, 2015
@wholmgren
fix celltemp keys. make output a df. closes pvlib#54
36871d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api
Projects
None yet
Milestone
0.2
Development

No branches or pull requests
2 participants
@bmu @wholmgren