Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snow events parameter docs for Townsend snow loss model #1840

Merged
merged 4 commits into from Aug 24, 2023

Conversation

aturabi
Copy link
Contributor

@aturabi aturabi commented Aug 22, 2023

@aturabi aturabi marked this pull request as ready for review August 22, 2023 18:34
Copy link
Member

@cwhanse cwhanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @aturabi !

@cwhanse
Copy link
Member

cwhanse commented Aug 22, 2023

@kandersolar there are unrelated test failures. Weird.

@cwhanse cwhanse added this to the v0.10.2 milestone Aug 22, 2023
@kandersolar
Copy link
Member

@kandersolar there are unrelated test failures. Weird.

I suspect scipy/scipy#19103 is to blame, although I did not investigate locally.

Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should add a sentence to the second paragraph of the Notes section saying "The 1 inch threshold for snow events documented above is also based on private communication with the model's author.", or similar?

Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aturabi!

@kandersolar kandersolar merged commit d084baa into pvlib:main Aug 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update documentation for snow events parameter for Townsend snow loss model
3 participants