Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update snow events parameter docs for Townsend snow loss model #1840

Merged
merged 4 commits into from
Aug 24, 2023
Merged

Update snow events parameter docs for Townsend snow loss model #1840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
603c4e7
Update snow events definition for Townsend model
Aug 22, 2023
bbc4414
Update whatsnew
Aug 22, 2023
c5e2b04
Merge branch 'main' into main
aturabi Aug 22, 2023
aaee0de
Add note on origin of new definition
Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion docs/sphinx/source/whatsnew/v0.10.2.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,9 @@ Documentation
(:issue:`1741`, :pull:`1833`)
* Fix error in :py:func:`pvlib.iotools.get_pvgis_hourly` documentation of `surface_azimuth`.
(:issue:`1724`, :pull:`1838`)

* Update definition of snow events parameter for :py:func:`pvlib.snow.loss_townsend`.
(:issue:`1839`, :pull:`1840`)

Requirements
~~~~~~~~~~~~

Expand All @@ -51,3 +53,4 @@ Contributors
* Taos Transue (:ghuser:`reepoi`)
* NativeSci (:ghuser:`nativesci`)
* Lukas Grossar (:ghuser:`tongpu`)
* Areeba Turabi (:ghuser:`aturabi`)
10 changes: 7 additions & 3 deletions pvlib/snow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,8 +230,10 @@ def loss_townsend(snow_total, snow_events, surface_tilt, relative_humidity,
Snow received each month. Referred to as S in [1]_. [cm]

snow_events : array-like
Number of snowfall events each month. May be int or float type for
the average events in a typical month. Referred to as N in [1]_.
Number of snowfall events each month. Snow events are defined as days
in the month that have snowfall greater than 1 inch. May be int or
float type for the average events in a typical month. Referred to as N
in [1]_.

surface_tilt : float
Tilt angle of the array. [deg]
Expand Down Expand Up @@ -274,7 +276,9 @@ def loss_townsend(snow_total, snow_events, surface_tilt, relative_humidity,
axis to the module edge.

The parameter `string_factor` is an enhancement added to the model after
publication of [1]_ per private communication with the model's author.
publication of [1]_ per private communication with the model's author. The
definition for snow events documented above is also based on private
communication with the model's author.

References
----------
Expand Down