Fix for obscure bug when running in VM #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that vm.runInContext() causes the "instanceof" tests to fail. Let's use more reliable .constructor.name tests, instead.
|
Might this actually be a bug in the Node core VM module? Maybe. |
|
Thank you for the hint. I haven't used the VM module yet, so I don't know if it's a bug in the VM module. There's an interesting thread on this issue nodejs/node-v0.x-archive#1277. |
|
Good cross-reference. |
|
I think I'll have a closer look on this during the weekend. |
|
I had the time to have a look on it. All your changes look very good and I'll merge now. Thanks a lot for your effort. |
pvorb
added a commit
that referenced
this pull request
Nov 25, 2012
Fix for obscure bug when running in VM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that
vm.runInContext()causes theinstanceoftests to fail. Let's use more reliable.constructor.nametests, instead.