Skip to content
This repository has been archived by the owner on Dec 2, 2022. It is now read-only.

Added EventType: "desktop_notification" #70

Closed
wants to merge 1 commit into from

Conversation

sgr-ksmt
Copy link

  • Add EventType "desktop_notification".

SlackKit currently output error log when received as below:

{
  "content": "user: @bot abcdef",
  "event_ts": 1484119301.624465,
  "launchUri": "slack://channel?id=xxxxx&message=1484119301000012&team=xxxxx",
  "subtitle": "#xxxxx",
  "ssbFilename": "knock_brush.mp3",
  "title": "xxxxx",
  "channel": "xxxxx",
  "avatarImage": "https://avatars.slack-edge.com/xxxxx.png",
  "type": "desktop_notification",
  "imageUri": null,
  "msg": 1484119301.000012
}

then output log:

Error: SlackKit.Event

@pvzig
Copy link
Owner

pvzig commented Jan 17, 2017

Thanks for the PR!

Since this isn't officially supported by Slack I don't think I want to specifically add it as an event type but unsupported events shouldn't be logged as errors either.

Fixed here.

@pvzig pvzig closed this Jan 17, 2017
@sgr-ksmt sgr-ksmt deleted the add_event_type branch January 17, 2017 05:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants