Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VSCODE / Starter] Service Workers should be greatly simplified #2672

Closed
jgw96 opened this issue Mar 4, 2022 · 3 comments · Fixed by #3295
Closed

[VSCODE / Starter] Service Workers should be greatly simplified #2672

jgw96 opened this issue Mar 4, 2022 · 3 comments · Fixed by #3295

Comments

@jgw96
Copy link
Contributor

jgw96 commented Mar 4, 2022

Tell us about your feature idea

While https://developers.google.com/web/tools/workbox/ is great for more complex setups, many users don't actually need the features Workbox has, which makes the added complexity of using Workbox not very worth it.

For example, our only negative review right now on the VSCode Extension is actually talking about Workbox issues, not PWA Studio issues.

Do you have an implementation or a solution in mind?

We should write a plain Service Worker, using plain JavaScript, that is the default Service Worker that users can generate. This plain Service Worker should serve as a good "base" for users to build off of. This plain Service Worker should:

  • Cache Images
  • Cache Fonts

if those types of assets are requested.

We should then have an advanced option that uses our current Workbox flow.

Have you considered any alternatives?

No response

@ghost
Copy link

ghost commented Mar 19, 2022

This issue has been marked as "needs attention 👋" due to no activity for 15 days. Please triage the issue so the fix can be established.

1 similar comment
@ghost
Copy link

ghost commented Apr 3, 2022

This issue has been marked as "needs attention 👋" due to no activity for 15 days. Please triage the issue so the fix can be established.

@jgw96 jgw96 changed the title [VSCODE] Service Workers should be greatly simplified [VSCODE / Starter] Service Workers should be greatly simplified Jun 2, 2022
@beth-panx
Copy link
Contributor

I think this makes tons of sense! It would also eliminate the "why is there no service worker from generation process" question. I always wanted to learn the bare bone (simplest) way of starting any project. And have the freedom to learn more if I wanted a rather complex configuration.

@ghost ghost locked as resolved and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done ✔️
Development

Successfully merging a pull request may close this issue.

3 participants