Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(): Simplify Service Workers setup in Studio #3295

Merged
merged 6 commits into from
Aug 18, 2022
Merged

feat(): Simplify Service Workers setup in Studio #3295

merged 6 commits into from
Aug 18, 2022

Conversation

jgw96
Copy link
Contributor

@jgw96 jgw96 commented Aug 16, 2022

fixes #2672

PR Type

Feature

Describe the current behavior?

All service workers (both the basic and advanced options) used workbox. Workbox has ended up being overkill for many a project, and can lead to un-needed complexity.

Describe the new behavior?

The new "basic" option is now just a standard, vanilla JS service worker that offers offline.

PR Checklist

  • [x ] Test: run npm run test and ensure that all tests pass
  • [x ] Target main branch (or an appropriate release branch if appropriate for a bug fix)
  • [x ] Ensure that your contribution follows standard accessibility guidelines. Use tools like https://webhint.io/ to validate your changes.

Additional Information

@ghost
Copy link

ghost commented Aug 16, 2022

Thanks jgw96 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@jgw96 jgw96 merged commit f94218c into main Aug 18, 2022
@jgw96 jgw96 deleted the simple-workers branch August 18, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[VSCODE / Starter] Service Workers should be greatly simplified
1 participant