Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Clicking 'No' under "Did you add your manifest" results in no action #4614

Closed
zateutsch opened this issue Jan 16, 2024 · 0 comments
Closed

[BUG] Clicking 'No' under "Did you add your manifest" results in no action #4614

zateutsch opened this issue Jan 16, 2024 · 0 comments
Assignees
@zateutsch
Labels
bug 🐛 site

Comments

@zateutsch
Copy link
Contributor

What happened?

If you edit your manifest and then click the notification under action items, the dialogue that opens has a "No" button that does nothing.

image

How do we reproduce the behavior?

  1. Test site on PWABuilder.
  2. Open manifest editor and make any change to manifest.
  3. Close editor.
  4. Click retest notification under action items that appears.
  5. Click 'No' when prompted.
  6. Nothing happens.

What do you expect to happen?

When the user clicks no, a dialogue should appear that reminds them to add their new manifest before trying to retest.

What environment were you using?

OS: Windows 11
Browser: Edge

Additional context

I'll take this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zateutsch zateutsch

Labels
bug 🐛 site
Projects
PWABuilder
Status: Done ✔️
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zateutsch