New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Py3k #21
Support for Py3k #21
Conversation
Nice work, though the tests failed, could you fix that? Also, do you need to |
Can u tell, how to make "test"? i don't know travis. what to install in pip, what to run |
You should be able to run |
almost. I have error
during run of test.py. |
Ahh, you're on Windows. It's trying to invoke the original figlet and toilet to compare the results. I can't easily help you run them unless you know how to install these on windows. |
So what about it |
Apologies @Alexey-T, your help is very much appreciated! Please be patient since I'm very busy at the moment and want to review it reasonably, hope you don't mind! :) Please do ping me again if you don't hear from me in a few days. |
Hi, Just had a look, looks good, except that the tests fail on python 3: https://travis-ci.org/pwaller/pyfiglet/jobs/19937917#L463 In test.py it just needs to be updated: diff --git a/pyfiglet/test.py b/pyfiglet/test.py
diff --git a/pyfiglet/test.py b/pyfiglet/test.py
index 3812fe5..8af839c 100755
--- a/pyfiglet/test.py
+++ b/pyfiglet/test.py
@@ -45,7 +45,7 @@ def main():
raise Exception('Missing font file: '+fontpath)
p = Popen(cmd, bufsize=1,stdout=PIPE)
- outputFiglet = p.communicate()[0]
+ outputFiglet = p.communicate()[0].decode("ascii")
if outputPyfiglet == outputFiglet:
print('[OK] %s' % font) Then I think it's good for merging. |
Added this |
No description provided.