Possible memory leak

[lion4ik]

https://github.com/pwittchen/ReactiveNetwork/blob/RxJava2.x/library/src/main/java/com/github/pwittchen/reactivenetwork/library/rx2/network/observing/strategy/PreLollipopNetworkObservingStrategy.java#L70

unregisterReceiver never be called. So, BroadcastReceiver will be leaked. I've tried to set up break point on this line and this was not called, howerer I disposed my Disposable.

[pwittchen]

Thanks for reporting this issue. Are you sure PreLollipopNetworkObservingStrategy was used in your case? Maybe different strategy was used and that may be the reason, this method wasn't called.

…

On Thu, Aug 31, 2017 at 11:58 AM, Alexey ***@***.***> wrote: https://github.com/pwittchen/ReactiveNetwork/blob/RxJava2. x/library/src/main/java/com/github/pwittchen/reactivenetwork/library/rx2/ network/observing/strategy/PreLollipopNetworkObservingStrategy.java#L70 unregisterReceiver never be called. So, BroadcastReceiver will be leaked. I've tried to set up break point on this line and this was not called, howerer I disposed my Disposable. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#219>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAqcF_iL6fUbOj9vlnravamAHz95W9wlks5sdoPDgaJpZM4PImQN> .

-- Piotr Wittchen http://wittchen.biz.pl

[lion4ik]

Yes, I am sure because I've tested it on api 19

[pwittchen]

Ok, I'll investigate that issue.

[lion4ik]

I've done pull request with fix #220

[pwittchen]

Ok, thanks.

[pwittchen]

PR merged. Fix will be available in the next release.

[lion4ik]

thanks, when do you plan next release?

[pwittchen]

I think I'll release it today. There's not much effort to do it. Later, we just need to wait for Maven Sync, so the new version should be available on Maven Central Repository in 48 hours or earlier.

If you want to be up to date with the upcoming release, you can track issue #221.

[pwittchen]

@lion4ik new release is already there: https://github.com/pwittchen/ReactiveNetwork#download

enjoy :)

[lion4ik]

@pwittchen thank you very much! I've already done with update version