Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue Possible memory leak #219 #220

Merged
merged 1 commit into from
Sep 2, 2017

Conversation

lion4ik
Copy link

@lion4ik lion4ik commented Aug 31, 2017

I've fixed this memory leak. Please look through. I would be grateful if you could do it quickly. It affects me on production ((

@codecov-io
Copy link

Codecov Report

Merging #220 into RxJava2.x will increase coverage by 1.68%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##           RxJava2.x     #220      +/-   ##
=============================================
+ Coverage      75.94%   77.62%   +1.68%     
=============================================
  Files             10       10              
  Lines            370      371       +1     
  Branches          33       33              
=============================================
+ Hits             281      288       +7     
+ Misses            65       58       -7     
- Partials          24       25       +1
Impacted Files Coverage Δ
.../strategy/PreLollipopNetworkObservingStrategy.java 66.66% <100%> (+19.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e65392...c9d1739. Read the comment docs.

@lion4ik lion4ik mentioned this pull request Aug 31, 2017
@pwittchen
Copy link
Owner

pwittchen commented Aug 31, 2017

Thanks for you PR. The fix looks fine. I'll just test it and I think, it could be merged ASAP.

@pwittchen pwittchen merged commit c9d1739 into pwittchen:RxJava2.x Sep 2, 2017
@pwittchen
Copy link
Owner

pwittchen commented Sep 2, 2017

I merged this update, added a missing unit test for bug proof and made tiny refactoring.

Fix will be available in the next release.

Thanks @lion4ik!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants